Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumType=Ord tokens missing NumForm annotations #28

Open
rhdunn opened this issue Oct 27, 2023 · 0 comments
Open

NumType=Ord tokens missing NumForm annotations #28

rhdunn opened this issue Oct 27, 2023 · 0 comments

Comments

@rhdunn
Copy link

rhdunn commented Oct 27, 2023

The word forms (first, third, etc.) should use NumForm=Word and the number-based forms (1st, 3rd, etc.) should use NumForm=Combi.

Validation issues:

ERROR: Sentence n01014003 token 9 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence n01016014 token 21 -- NumType=Ord should be paired with NumForm=Word for form 'third'
ERROR: Sentence n01034060 token 8 -- NumType=Ord should be paired with NumForm=Combi for form '45th'
ERROR: Sentence n01038025 token 10 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence n01039039 token 10 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence n01061016 token 9 -- NumType=Ord should be paired with NumForm=Word for form 'First'
ERROR: Sentence n01067023 token 6 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01004051 token 10 -- NumType=Ord should be paired with NumForm=Combi for form '5th'
ERROR: Sentence w01006027 token 6 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01010044 token 22 -- NumType=Ord should be paired with NumForm=Combi for form '6th'
ERROR: Sentence w01010045 token 6 -- NumType=Ord should be paired with NumForm=Combi for form '8th'
ERROR: Sentence w01010047 token 2 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01028004 token 2 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01045002 token 30 -- NumType=Ord should be paired with NumForm=Combi for form '15th'
ERROR: Sentence w01045004 token 3 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01045005 token 3 -- NumType=Ord should be paired with NumForm=Combi for form '16th'
ERROR: Sentence w01049066 token 15 -- NumType=Ord should be paired with NumForm=Word for form 'second'
ERROR: Sentence w01051080 token 4 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01065022 token 9 -- NumType=Ord should be paired with NumForm=Combi for form '14th'
ERROR: Sentence w01071043 token 10 -- NumType=Ord should be paired with NumForm=Word for form 'third'
ERROR: Sentence w01072065 token 3 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01072079 token 3 -- NumType=Ord should be paired with NumForm=Combi for form '3rd'
ERROR: Sentence w01073007 token 17 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01076054 token 31 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01084102 token 8 -- NumType=Ord should be paired with NumForm=Combi for form '16th'
ERROR: Sentence w01094022 token 12 -- NumType=Ord should be paired with NumForm=Combi for form '20th'
ERROR: Sentence w01097104 token 24 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01116036 token 8 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01119076 token 10 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01142013 token 10 -- NumType=Ord should be paired with NumForm=Combi for form '3rd'
ERROR: Sentence w01144031 token 7 -- NumType=Ord should be paired with NumForm=Word for form 'third'
ERROR: Sentence w01144063 token 7 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01144084 token 15 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w01147122 token 14 -- NumType=Ord should be paired with NumForm=Word for form 'third'
ERROR: Sentence n02044009 token 17 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence n03002003 token 12 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence n03003036 token 2 -- NumType=Ord should be paired with NumForm=Word for form 'third'
ERROR: Sentence n03007011 token 7 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence n04010017 token 5 -- NumType=Ord should be paired with NumForm=Word for form 'fourth'
ERROR: Sentence n05002004 token 3 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w02002120 token 25 -- NumType=Ord should be paired with NumForm=Word for form 'Second'
ERROR: Sentence w02004021 token 10 -- NumType=Ord should be paired with NumForm=Combi for form '13th'
ERROR: Sentence w02008028 token 17 -- NumType=Ord should be paired with NumForm=Combi for form '5th'
ERROR: Sentence w02011029 token 4 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w02012042 token 2 -- NumType=Ord should be paired with NumForm=Word for form 'First'
ERROR: Sentence w02016060 token 25 -- NumType=Ord should be paired with NumForm=Word for form 'second'
ERROR: Sentence w03005012 token 3 -- NumType=Ord should be paired with NumForm=Combi for form '8th'
ERROR: Sentence w03005014 token 3 -- NumType=Ord should be paired with NumForm=Combi for form '9th'
ERROR: Sentence w03005014 token 8 -- NumType=Ord should be paired with NumForm=Word for form 'first'
ERROR: Sentence w03005016 token 4 -- NumType=Ord should be paired with NumForm=Combi for form '8th'
ERROR: Sentence w04004051 token 2 -- NumType=Ord should be paired with NumForm=Word for form 'second'
ERROR: Sentence w04007021 token 26 -- NumType=Ord should be paired with NumForm=Word for form 'second'
ERROR: Sentence w05001026 token 3 -- NumType=Ord should be paired with NumForm=Combi for form '20th'
ERROR: Sentence w05004031 token 7 -- NumType=Ord should be paired with NumForm=Word for form 'second'
ERROR: Sentence w05010027 token 3 -- NumType=Ord should be paired with NumForm=Combi for form '1st'
AngledLuffa added a commit that referenced this issue Oct 28, 2023
Done with the following Ssurgeon script, although it relies on a couple unreleased features:

{word:/^[0-9a-zA-Z]+$/;morphofeatures:/^.*NumType=Ord.*$/}=number
EditNode -node number -updateMorphoFeatures NumForm=Combi

{word:/^[a-zA-Z]+$/;morphofeatures:/^.*NumType=Ord.*$/}=number
EditNode -node number -updateMorphoFeatures NumForm=Word
AngledLuffa added a commit that referenced this issue Oct 28, 2023
Done with the following Ssurgeon script, although it relies on a couple unreleased features:

{word:/^[0-9a-zA-Z]+$/;morphofeatures:/^.*NumType=Ord.*$/}=number
EditNode -node number -updateMorphoFeatures NumForm=Combi

{word:/^[a-zA-Z]+$/;morphofeatures:/^.*NumType=Ord.*$/}=number
EditNode -node number -updateMorphoFeatures NumForm=Word
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant