From 9263f724aaf340cb66045e8de6a725bb2c4c7577 Mon Sep 17 00:00:00 2001 From: David Leek Date: Tue, 13 Aug 2024 09:54:18 +0200 Subject: [PATCH] feat: always reset stream position after call to serializer (#235) * feat: always reset stream position after call to serializer * docs: remove setting stream position from custom serializer sample --- README.md | 1 - src/Unleash/Communication/UnleashApiClient.cs | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 4a306c1d..8d5854b8 100644 --- a/README.md +++ b/README.md @@ -533,7 +533,6 @@ public class NewtonsoftJson7Serializer : IJsonSerializer Serializer.Serialize(jsonWriter, instance); jsonWriter.Flush(); - stream.Position = 0; } } diff --git a/src/Unleash/Communication/UnleashApiClient.cs b/src/Unleash/Communication/UnleashApiClient.cs index 184a2969..f44cdf56 100644 --- a/src/Unleash/Communication/UnleashApiClient.cs +++ b/src/Unleash/Communication/UnleashApiClient.cs @@ -187,6 +187,7 @@ public async Task RegisterClient(ClientRegistration registration, Cancella var memoryStream = new MemoryStream(); jsonSerializer.Serialize(memoryStream, registration); + memoryStream.Position = 0; const int bufferSize = 1024 * 4; @@ -233,6 +234,7 @@ public async Task SendMetrics(ThreadSafeMetricsBucket metrics, Cancellatio InstanceId = clientRequestHeaders.InstanceTag, Bucket = bucket }); + memoryStream.Position = 0; } const int bufferSize = 1024 * 4;