Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinitely blocked in metrics.count with gitlab #139

Closed
c0olix opened this issue Sep 6, 2023 · 3 comments · Fixed by #143
Closed

infinitely blocked in metrics.count with gitlab #139

c0olix opened this issue Sep 6, 2023 · 3 comments · Fixed by #143
Assignees
Labels

Comments

@c0olix
Copy link

c0olix commented Sep 6, 2023

Describe the bug

I am using Gitlab as unleash API, and I came across an error, where a request for an API-call against my microservice was timed out, since it never leaves the isEnabled func. After debugging I found out, that the metrics count in the defer is blocking infinitely.
https://github.com/Unleash/unleash-client-go/blob/v3/client.go#L243
Further it was really hard to figure this out as it is in the defer. I know, that I can disable the metrics, and that`s my fix for it, but imho this should not block. It should return an error instead or panic, but it was really hard to figure this out.

Steps to reproduce the bug

No response

Expected behavior

No blocking

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

3.8.0

Subscription type

None

Hosting type

None

SDK information (language and version)

Go

@c0olix c0olix added the bug label Sep 6, 2023
@nunogois
Copy link
Member

nunogois commented Sep 6, 2023

Hi @c0olix, thanks for raising this issue. I'll reach out to the rest of the team and then get back to you.

@daveleek
Copy link
Contributor

daveleek commented Sep 28, 2023

Hello @c0olix. We apologize, this appears to have slipped our attention. Has this issue been resolved, or is this still an issue you're experiencing?

@daveleek
Copy link
Contributor

daveleek commented Oct 2, 2023

Hello again @c0olix. We have reproduced this issue and are working on a fix. The issue is due to messaging blocking when no listeners have been configured. So in the meantime until we can get a fix out a workaround is to include the
unleash.WithListener(&unleash.DebugListener{}), in the unleash initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants