Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type to api.Feature #162

Closed
jameshartig opened this issue Dec 7, 2023 · 1 comment · Fixed by #168
Closed

Add Type to api.Feature #162

jameshartig opened this issue Dec 7, 2023 · 1 comment · Fixed by #168

Comments

@jameshartig
Copy link
Contributor

Describe the feature request

The API returns the type of the feature. It should be added as a struct field on api.Feature.

Background

We will have some special metrics around kill-switch type features to specifically track when those are being enabled to kill features.

Solution suggestions

Add Type string field to api.Feature.

@jameshartig
Copy link
Contributor Author

@FredrikOseberg this one was simple enough that I just opened a PR. There's a bigger discussion around ease of getting to the *api.Feature but I believe we have a workaround internally that doesn't involve any change to the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant