test: separate specification tests from race conditions tests #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
requested review from
chriswk,
FredrikOseberg,
gastonfournier and
sjaanus
gastonfournier
approved these changes
Nov 22, 2023
kwasniew
added a commit
that referenced
this pull request
Nov 22, 2023
kwasniew
added a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Separating specification tests (regular tests) and SDK internal tests (run with resource heavy race detection) using build tag I called
norace.Also found that some gradual rollout tests creating 200000 iterations which are a good candidate for exclusion from the race condition tests.
Important files
Discussion points