Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update comment #180

Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Sep 19, 2024

Relates to a related fix done in some other sdks, such as the node one at
Unleash/unleash-client-node#417

In this case, the comment was misleading, so we can edit it.

@thomasheartman thomasheartman force-pushed the fix/1-2864-investigate-rollout-distribution-issues branch from 5da64ab to acf3b85 Compare September 19, 2024 08:53
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasheartman thomasheartman changed the title fix: delete unused method and update comment chore: update comment Sep 19, 2024
@thomasheartman thomasheartman merged commit 9ed9c22 into v4 Sep 19, 2024
20 checks passed
@thomasheartman thomasheartman deleted the fix/1-2864-investigate-rollout-distribution-issues branch September 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants