chore: fix invalid dom nesting #8451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
thomasheartman
changed the title
thomasheartman
changed the title
This reverts commit 7ba01ec.
thomasheartman
changed the title
thomasheartman
deleted the
chore/1-2988-fix-warnings-in-front-end-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all
invalidDomNestingerrors we're getting in our tests. The culprit was theBadgeicon we use, which wrapped its children in a div. When that's used as a child of aptag, that'd cause this to trigger.What I've done is to change the wrapping element to a span instead. The Badge itself uses an
display: inline-flex, so divs and spans should be treated the same, meaning there's no visual change for this.