Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: etag support RFC 9110 standard #9077

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix: etag support RFC 9110 standard #9077

merged 2 commits into from
Jan 10, 2025

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Jan 10, 2025

ETag must be in double quotes based on standard. Fixing it.

If-None-Match: "<etag_value>"

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:37am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:37am

Copy link
Contributor

@sjaanus, core features have been modified in this pull request. Please review carefully!

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjaanus sjaanus merged commit fda2252 into main Jan 10, 2025
10 checks passed
@sjaanus sjaanus deleted the etag-work branch January 10, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants