feat: add facility context switch and ui #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calisio
force-pushed
the
facilities-dropdown
branch
from
51e3532 to
ef18378
Compare
jtucholski
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Looks good. I added two comments in there and am interested in what your thoughts are:
- Cleaning up the
classNameattributes in the NavBar. (request to have that cleaned up) - The placement of the router loaders for the facility data. (open to further discussion)
calisio
force-pushed
the
facilities-dropdown
branch
from
ef18378 to
5bc6fbb
Compare
jtucholski
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds facility context switching on the admin side. It also updates both the admin and student portal to display the current facility in the PageNav component, and moves the dropdown that contains logout and theme toggle to the Navbar component. Also updates the routes to not pass in the facility name in the path as it's not needed anymore. Adds loader to the admin Authentication Layout route to render facilities.
Screenshot(s)
Screen.Recording.2024-10-25.at.12.36.35.PM.mov
Additional Notes
I want to make sure the UI aligns with what @chrissantillan was looking for.