Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup react recommended #458

Closed
wants to merge 3 commits into from
Closed

Conversation

Huijiro
Copy link
Contributor

@Huijiro Huijiro commented Oct 25, 2024

EDIT (Preston):
Setup react eslint recommended lints.

Fixes will have to be pushed to this branch in order for the CI to pass and merge.

@calisio
Copy link
Contributor

calisio commented Oct 29, 2024

Is this a draft (still being worked on to fix the lints) or is it ready for review? How do we want to approach it? Reviewing thousands of lines of code seems tough haha so I might have to do it over a few days. Are there any things in particular I should be looking out for?

@PThorpe92
Copy link
Member

PThorpe92 commented Nov 12, 2024

sorry @calisio I didn't see that comment. i was waiting for all the other PR's to merge.

this is just lints, so it shouldn't be much to review really. i'll fix the conflicts and make sure nothing breaks

EDIT: I think I want to remove the lints for the react compiler and just stick to react recommended

@PThorpe92
Copy link
Member

I tried my best to catch this up with the repo but I'm afraid there is too many conflicts. Would be easier at this point to setup react just recommended on the main branch.

Thanks for the PR, closing this for now.

@PThorpe92 PThorpe92 closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants