#4 Impl ImportCourses for BrightspaceService #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
reviewed
Nov 6, 2024
| return urlRes.Data.Url, nil | ||
| } | ||
|
|
||
| func getDefaultImg() ([]byte, error) { |
There was a problem hiding this comment.
In the case that the download fails, can we have this just set the ThumbnailURL to /brightspace.png which we can keep in the /frontend/public directory, so we don't have to read and upload this default image each time?
There was a problem hiding this comment.
Yeah, much more efficient. I'll make the change in the upcoming PR. Ah, I just seen that you made the change already. Thanks!
…for integration of courses
…ration of courses
PThorpe92
force-pushed
the
init_brightspace_courses
branch
from
a56519c to
ae62b1a
Compare
PThorpe92
force-pushed
the
init_brightspace_courses
branch
from
ae62b1a to
735df2b
Compare
PThorpe92
approved these changes
Nov 6, 2024
PThorpe92
added a commit
that referenced
this pull request
Nov 12, 2024
* feat: add initial csvs local directory and default brightspace image for integration of courses * fix: modify gorm criteria for ProviderPlatform state to be enabled * feat: add Brightspace ProviderPlatformType for integration of courses * feat: add gocarina/gocvs library used for reading csv files for integration of courses * feat: add logic for the integration of brightspace courses * fix: use brightspace default img path --------- Co-authored-by: PThorpe92 <preston@unlockedlabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PThorpe92 Initial implementation of ImportCourses for BrightspaceService. Retrieves CSV from Brightspace REST API, parses the CSV into UnlockEd type course, if the Brightspace course does not exist within UnlockEd, makes REST API call to retrieve course images and if one does not exist a default one is used. Example of implemented courses: