fix: set logging back to stdout to access logs in kubectl #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carddev81
reviewed
Dec 29, 2024
| @@ -7,6 +7,8 @@ import ( | |||
| "net/http" | |||
| "net/url" | |||
| "strconv" | |||
|
|
|||
| "github.com/sirupsen/logrus" | |||
There was a problem hiding this comment.
Should the alias log be added here for consistency? I noticed in most places within code the alias is used.
There was a problem hiding this comment.
we use log for the variable name of the sLog wrapper in our custom handlers, so it would conflict. I'm beginning to wish I never alias'ed logrus in the first place :/ we should slowly change it back
backend/src/models/jobs.go
Outdated
| @@ -74,7 +74,7 @@ const ( | |||
| SyncVideoMetadataJob JobType = "sync_video_metadata" | |||
| PutVideoMetadataJob JobType = "put_video_metadata" | |||
| AddVideosJob JobType = "add_videos" | |||
| EveryThreeHours string = "0 */3 * * *" | |||
| EveryThreeHours string = "0 6-20 * * *" | |||
There was a problem hiding this comment.
Since the cron changed to every hour vs every 3 hours, should the variable name be changed to reflect this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.