-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learning insights dash #624
Merged
PThorpe92
merged 15 commits into
UnlockedLabs:main
from
corypride:learning-insights-dash
Jan 13, 2025
Merged
Learning insights dash #624
PThorpe92
merged 15 commits into
UnlockedLabs:main
from
corypride:learning-insights-dash
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calisio
reviewed
Jan 7, 2025
calisio
reviewed
Jan 7, 2025
calisio
reviewed
Jan 7, 2025
calisio
reviewed
Jan 7, 2025
Table is not filtered by facility yet
…On Tue, Jan 7, 2025 at 11:54 AM Carolina Alisio ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On frontend/src/Pages/AdminLayer2.tsx
<#624 (comment)>
:
Not sure what the stemming issue is, but I was messing with the frontend
to see if the stats match up, and when I switched to my third facility
(Potosi Correctional), it said 0 courses offered and 0 enrollments but then
the course metrics table was filled out with the same 10 courses as the
previous facility. It could just be my seeded data acting weird, but worth
it to check out. See images below
Screenshot.2025-01-07.at.11.51.26.AM.png (view on web)
<https://github.com/user-attachments/assets/f607697c-a824-4b73-9601-f9af704a300d>
Screenshot.2025-01-07.at.11.49.10.AM.png (view on web)
<https://github.com/user-attachments/assets/303884aa-f617-4f04-8b58-93d9683283b9>
Could it be that the "Course Metrics" table is listing all courses in all
facilities with their enrollments? Do we want that table to be updated
according to the selected facility, or do we want it to display all courses
across all facilities? If we would like it to consistently display all
courses in all facilities (which i believe is the behavior it is doing
right now), I think it would be worth having a conversation about how we
can display the facility filter in a less confusing spot, since right now
the user probably assumes that that filter will update the entire page
including the course metrics table. Let me know your thoughts
—
Reply to this email directly, view it on GitHub
<#624 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A43WLSGMOIEKLRPGLADMAPL2JQIE5AVCNFSM6AAAAABUWYO7UWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZVGAZTSOBXGE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
calisio
reviewed
Jan 8, 2025
calisio
reviewed
Jan 8, 2025
calisio
reviewed
Jan 8, 2025
calisio
reviewed
Jan 8, 2025
calisio
reviewed
Jan 8, 2025
calisio
reviewed
Jan 8, 2025
calisio
reviewed
Jan 8, 2025
calisio
reviewed
Jan 8, 2025
calisio
reviewed
Jan 9, 2025
jtucholski
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments about splitting up the GetAdminLayer2Info function call and leaving the logic to aggregate it in the handler. This is similar to what we also arrived at for the Operational Insights.
…s for each query in learning_insights
PThorpe92
reviewed
Jan 10, 2025
PThorpe92
reviewed
Jan 10, 2025
PThorpe92
reviewed
Jan 10, 2025
PThorpe92
reviewed
Jan 11, 2025
PThorpe92
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Update the Admin Layer 2 Dashboard for student activity (named Learning Insights) so that it shows the data relative to courses, student enrollments and activity time, all which have the option to be filtered by facility
Screenshot(s)