fix: add tooltips and line charts to operational insight #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtucholski
requested changes
Jan 8, 2025
CK-7vn
force-pushed
the
op_insights
branch
2 times, most recently
from
3e178c2 to
c7954c7
Compare
|
A lot of updates here. -- Updated the facilities API call to use SWR. (Small, key in on the x axis labels) 3 hr x axis 2 hr x axis
|
CK-7vn
force-pushed
the
op_insights
branch
2 times, most recently
from
967a0f1 to
4e5d074
Compare
jtucholski
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Two small changes
- Try changing some of the step values for the chart to have even greater intervals. There's a point still where the values in there are squeezed together.
- Look into using the DaisyUI or Tailwind Tooltips that we use throughout the app so you don't need to fight the DOM in the ToolTipIcon component.
jtucholski
approved these changes
Jan 10, 2025
jtucholski
approved these changes
Jan 10, 2025
jtucholski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This fixes the wordage on the operational insights dashboard for the cards, removed logins per day, and both the pie chart, and bar graph in the peak login times. Total users was changed to include admins, so now users include the totality of the users. Users = total people using the platform, Admins = everyone except residents (students per user roles), Residents = anyone in student role.
The tooltip was changed to reflect the theme so there is no longer issues with the coloring as well.
In the StatsCard's ternary's were added to check the count of the data being returned/rendered so that the pluralism was correct as well.
Changes "Students" in navbar to "Residents" as well.
Screenshot(s)
When hovering the tooltip displays the time in 24hr time
