fix: add titles for pages #632
Conversation
There was a problem hiding this comment.
This PR looks good to me, but I am a little confused on the "additional context" comment. Is there anything we need to do to fix these errors?
Also, just wanted to confirm we are just updating the page titles and not adding in the extra page titles in the top breadcrumbs nav. If we are just sticking to the tab page titles, I can go ahead and merge!
Not updating breadcrumbs as to my knowledge, Preston said to ignore the errors for now, they don't cause any issues, and it's only once the links lead somewhere external, only thing that will happen, is at that point the title will stop updating, that's the worst thing that happens! |
Description of the change
This PR adds dynamic title changes for pages. In the library viewer the TitleManager checks to see if we are in the library viewer, if we are it gives an explicit 5 second timeout to wait for the iFrame to load the content, after that pulls the title tag from inside of the document and then renders it as the Title for the parent DOM.
Screenshot(s)
1'st layer
2'nd nested layer inside of the library viewer
5 layers deep
Additional context
There is an issue in which if the user clicks on a link inside of the iFrame that is cross-site, the title will not change, and there will be errors in the console, but, this does not effect any of the functionality outside of that.