Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: standardize toaster messages #635

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix: standardize toaster messages #635

merged 2 commits into from
Jan 14, 2025

Conversation

calisio
Copy link
Contributor

@calisio calisio commented Jan 7, 2025

Description of the change

Updates all toasters to be capitalized. Also condenses some of the toggle functions into one.

@jtucholski jtucholski self-requested a review January 10, 2025 16:00
jtucholski
jtucholski requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@jtucholski jtucholski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few comments around consistency in here.

Can you also see if we can improve the messaging for favoriting/unfavoriting/hiding/showing so that the user doesn't see "state" in the toaster message?

frontend/src/Components/cards/HelpfulLinkCard.tsx Outdated Show resolved Hide resolved
frontend/src/Components/LibraryCard.tsx Show resolved Hide resolved
frontend/src/Components/VideoCard.tsx Outdated Show resolved Hide resolved
frontend/src/Pages/AdminManagement.tsx Outdated Show resolved Hide resolved
frontend/src/Pages/HelpfulLinksManagement.tsx Outdated Show resolved Hide resolved
frontend/src/Pages/StudentManagement.tsx Outdated Show resolved Hide resolved
@jtucholski jtucholski mentioned this pull request Jan 10, 2025
Open
@calisio
Copy link
Contributor Author

calisio commented Jan 13, 2025

@jtucholski should now be updated with your requests!

@jtucholski jtucholski changed the title fix: standardize toaster message fix: standardize toaster messages Jan 14, 2025
@jtucholski jtucholski merged commit 9b12a2f into UnlockedLabs:main Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PThorpe92 PThorpe92 PThorpe92 approved these changes

@jtucholski jtucholski jtucholski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calisio @jtucholski @PThorpe92