Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle translations #116

Open
joapuiib opened this issue Oct 17, 2022 · 1 comment
Open

Handle translations #116

joapuiib opened this issue Oct 17, 2022 · 1 comment

Comments

@joapuiib
Copy link

joapuiib commented Oct 17, 2022

Hi,
I love this Git tutorial and I'm currently translating it to Catalan in my fork: https://github.com/joapuiib/git_training/tree/master/translations/ca

I've created a folder named translations where a folder can be created for each language this tutorial is translated to. I don't know if this is the best approach. I'd like to hear from you and know if you think this is a good idea.

For now, I've been working on the master branch, but I've seen that tutorial_wip exists In order to not make the history "dirty". I could make the branch translation_catalan and then, merge it to master, but there would be a visible commit that would spoil the history if a lot of translations are being made.

Do you want to integrate translations and, if so, how would be the best way to add these changes?

@UnseenWizzard
Copy link
Owner

Hi @joapuiib sorry for the late reply, I've missed this!

This is great work!
I think adding a translations folder is fine, past contributions have already broken the idea to have a clear history of the main branch as part of the tutorial. 1000% better to have contributions :)

I'd be very happy if you open a PR adding your translation!
In terms of commits I'd just merge that as one commit saying something like "Add Catalan translation by @joapuiib"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants