Tidy up of the Search App #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisKSeal
reviewed
Jun 16, 2024
| if acl["token__id"] is not None: | ||
| # token access shouldn't be added to search | ||
| # unless search is given a way of checking token expiry | ||
| continue |
There was a problem hiding this comment.
Should this return None or something empty at this point? If I follow the code correctly this will return an acl dictionary without a pluginId or entityId, but will pick up the canDownload/canSensitive.
There was a problem hiding this comment.
Nvm - just realised my noob error 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves both the readability and flow of the Search App, specifically the document.py and api.py files