Ids 779 remove active directory lookup from ro crate gener (#1)

* remove active directory lookup * remove active directory lookup * black changes to removed active directory lookup
UoA-eResearch · Jun 4, 2024 · e600f38 · e600f38
1 parent c838e5e
commit e600f38
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 147 deletions.
diff --git a/examples_for_test/print_lab_test/sampledata.xlsx b/examples_for_test/print_lab_test/sampledata.xlsx
diff --git a/poetry.lock b/poetry.lock
diff --git a/src/mt_api/apiconfigs.py b/src/mt_api/apiconfigs.py
@@ -16,7 +16,6 @@
 from requests.models import PreparedRequest
 
 from src.mt_api.api_consts import CONNECTION__HOSTNAME
-from src.user_lookup.user_lookup import lookup_user
 
 from .mt_consts import UOA
 
@@ -206,11 +205,6 @@ def create_person_object(self, upi: str) -> Person:
         users_stub = "user/?username="
         name = upi
         email = ""
-        ldap_data = lookup_user(upi=upi)
-        if ldap_data is not None:
-            first_name, last_name, email = ldap_data
-            name = f"{first_name} {last_name}"
-            return Person(name=name, email=email, affiliation=UOA, identifiers=[upi])
         try:
             response = self.mytardis_api_request(
                 "GET", self.api_template + users_stub + upi
@@ -233,7 +227,9 @@ def create_person_object(self, upi: str) -> Person:
                         else email
                     )
         except RequestException as e:
-            logger.error("bad API response getting person data for %s: %s", upi, e)
+            logger.error(
+                "bad API response getting person data for %s. Error: %s.", upi, e
+            )
 
         return Person(name=name, email=email, affiliation=UOA, identifiers=[upi])
 

diff --git a/src/user_lookup/user_lookup.py b/src/user_lookup/user_lookup.py