Ids 779 remove active directory lookup from ro crate gener #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisKSeal
approved these changes
Jun 4, 2024
| logger.error("bad API response getting person data for %s: %s", upi, e) | ||
| logger.error( | ||
| "bad API response getting person data for %s. Error: %s.", upi, e | ||
| ) | ||
|
|
There was a problem hiding this comment.
What is the default behaviour if the API lookup fails? Do we create a Person with just the UPI or do we raise the exception? Also the API call should return any associated identifiers, if there are any, which we could/should include in the Person object. This is probably a later addition, but we do need to consider things like ORCID in this space :)
JLoveUOA
deleted the
IDS-779-remove-active-directory-lookup-from-ro-crate-gener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.