Cleanup CUDA, Reuse Memory, Add Serial Model, Cleaup Std Parallelism #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalobg
force-pushed
the
reuse_memory
branch
7 times, most recently
from
2b9129e
to
6c83420
Compare
This commit puts benchmarks in control of allocating the host memory used for verifying the results. This enables benchmarks that use Unified Memory for the device allocations, to avoid the host-side allocation and just pass pointers to the device allocation to the benchmark driver. Closes UoB-HPC#128 .
Closed
gonzalobg
changed the title
gonzalobg
commented
Sep 19, 2024
| #ifdef INDICES | ||
| // NVHPC workaround: TODO: remove this eventually | ||
| #if defined(__NVCOMPILER) && defined(_NVHPC_STDPAR_GPU) | ||
| #define WORKAROUND |
There was a problem hiding this comment.
Have a pragma message to print that workarounds are enabled.
gonzalobg
commented
Sep 19, 2024
| #else | ||
|
|
||
| // auto exe_policy = dpl::execution::seq; | ||
| // auto exe_policy = dpl::execution::par; | ||
| static constexpr auto exe_policy = dpl::execution::par_unseq; | ||
| #define USE_STD_PTR_ALLOC_DEALLOC | ||
| #define WORKAROUND |
There was a problem hiding this comment.
pragma message to highlight that there is a workaround
gonzalobg
commented
Sep 19, 2024
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| // Copyright (c) 2015-23 Tom Deakin, Simon McIntosh-Smith, and Tom Lin | |||
| // Copyright (c) 2015-16 Tom Deakin, Simon McIntosh-Smith, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup CUDA
Add Serial
By @tom91136 Good thing to have when comparing with other parallel programming models, mostly for syntax.
This also makes us consistent with CloverLeaf, TeaLeaf, and miniBUDE.
Reuse Memory
This PR puts benchmarks in control of allocating the host
memory used for verifying the results.
This enables benchmarks that use Unified Memory for the device
allocations, to avoid the host-side allocation and just pass
pointers to the device allocation to the benchmark driver.
Closes #128 .
Cleanup C++ Standard Parallelism
Merge the 3 implementations into one with different flags for data c++17, data c++23, and indices.
Also annotate workarounds with a
#define WORKAROUNDand print whether the current implementation is not conforming.Adds support for AdaptiveCpp (CI not added yet; will be done later as part of removing hipSYCL).