Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VPS-121] Retrieve and Save scene tags to database #126

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

arnard76
Copy link
Contributor

@arnard76 arnard76 commented Oct 12, 2023

Describe the issue

A clear and concise description of what the issue is.
#124

Describe the solution

A clear and concise description of what the solution is.

continuing #125
this saves tags to database when changed and reads from database too.

also implemented a default "No tag"
image

Risk

Potential risks that this PR might brings

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Arnav Shekaran added 8 commits October 12, 2023 13:52
includes:
- new components for each `SceneListItem` and the `SceneTagInput`
- currently only demo purposes
so tags are stored on the frontend
- user can click a tag to show the change tag input box
- currently the new tag doesn't get saved anywhere
- styles for everything
get from scenes for a scenario in the database
updates all tags for provided scenes
@arnard76 arnard76 added enhancement New feature or request frontend backend labels Oct 12, 2023
@arnard76 arnard76 self-assigned this Oct 12, 2023
@arnard76 arnard76 linked an issue Oct 12, 2023 that may be closed by this pull request
@arnard76 arnard76 requested a review from djos192 October 26, 2023 10:36
@djos192 djos192 merged commit 246e4dc into master Oct 26, 2023
6 checks passed
@harbassan harbassan deleted the VPS-121/save-scene-tag-changes branch April 24, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show which player tag is assigned to each scene
2 participants