Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPS-50/fix image bug #227

Merged
merged 4 commits into from
Aug 31, 2024
Merged

VPS-50/fix image bug #227

merged 4 commits into from
Aug 31, 2024

Conversation

codecreator127
Copy link
Contributor

Describe the issue

Buggy image upload in authoring tool

Describe the solution

Fixed save and close button to have a delay
Fixed uploadFile function in storage.js so that it returns a promise instead of just the url, so the image always gets uploaded first

Risk

Could break image upload

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Contributor

@JordanBlenn JordanBlenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked by Jin and I :)

@JordanBlenn JordanBlenn merged commit 7c0a6c2 into master Aug 31, 2024
8 checks passed
@JordanBlenn JordanBlenn deleted the VPS-50/fix-image-bug branch August 31, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants