Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPS-53/Image Upload Issue #232

Merged
merged 1 commit into from
Sep 16, 2024
Merged

VPS-53/Image Upload Issue #232

merged 1 commit into from
Sep 16, 2024

Conversation

codecreator127
Copy link
Contributor

AuthoringToolPage

Describe the issue

Images do not get saved correctly when saving quickly and leaving

Describe the solution

Added await to the savescene()

image

Risk

Might break images

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Contributor

@JordanBlenn JordanBlenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! good spotting

@codecreator127 codecreator127 merged commit 67eb339 into master Sep 16, 2024
7 checks passed
@codecreator127
Copy link
Contributor Author

nice! good spotting

thank you !

@JordanBlenn JordanBlenn deleted the VPS-53/image-saving-bug branch September 16, 2024 05:57
@Kot6603
Copy link
Contributor

Kot6603 commented Sep 16, 2024

nice! good spotting

it was the most difficult bug to find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants