fix: Fix invalid roles page not displaying #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjin-lee
requested review from
harbassan and
JordanBlenn
and removed request for
harbassan
harbassan
approved these changes
Sep 17, 2024
bcho892
approved these changes
Sep 17, 2024
| @@ -171,14 +171,15 @@ export default function ListContainer({ | |||
| </ImageListItem> | |||
| ) : null} | |||
| {assignedScenarios && assignedScenarios.length > 0 | |||
| ? assignedScenarios.map(({ _id, name }) => ( | |||
| ? assignedScenarios.map((item) => ( | |||
There was a problem hiding this comment.
ah - the tricky one here being that item can be a scenario or a scene.
The whole ListComponent shouldn't be the way it is... Ideally the contents are abstracted away, but alas, time is our limiting factor here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unintended behaviour where the a white screen is shown instead of the invalid roles page.
Addressing the "Also" tag:
"Also, refreshing causes you to get stuck on the invalid role page, and doesn’t allow you to move on even if another group member plays through their part (hack is to remove that part from the url but that won’t work for a test class for obvs reasons)."
The invalid roles page does provide a button to attempt to play the scenario again - we essentially bypass the need for a manual browser refresh.
Side note: