Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPS-45/Daisy UI Plugin #237

Merged
merged 2 commits into from
Sep 17, 2024
Merged

VPS-45/Daisy UI Plugin #237

merged 2 commits into from
Sep 17, 2024

Conversation

itsatulbox
Copy link
Contributor

Describe the issue

We are currently trying to update the UI of the project and we are wanting to use Daisy UI components in the project.

Describe the solution

Adding DaisyUI to the tailwing config file should allow everyone to use Daisy components by adding pieces of code like this:

<button class="btn">Button</button>

Risk

Could possibly make somethings look different right now but once we choose the correct theme, everything should look better

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - ty!

Minor change required: package-lock.json should not be committed!

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JordanBlenn
Copy link
Contributor

Great Job!

@itsatulbox itsatulbox merged commit e3d6fa4 into master Sep 17, 2024
5 checks passed
@itsatulbox itsatulbox deleted the VPS-45/daisy-ui-buttons branch September 17, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants