Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update home screen style #241

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Conversation

wjin-lee
Copy link
Member

@wjin-lee wjin-lee commented Sep 18, 2024

Description

  • Added the ability to toast.
  • Restyled the home page (TENTATIVE!)
  • Fixed broken inheritance chain for viewport height/width.

Important

This PR should not be merged until the appropriate design reviews have been carried out.
See the Discord thread for details.

Design

I am not sure if I like this - I would love some genuine feedback on design - I'm not sensitive, please criticise to your heart's content.

For comparison, here is the old design
image

To me, this design had a few points of improvement:
disclaimer: this is just my opinion, feel free to dispute this points!

  • The main action the user is expected is off to the left and is not emphasized - the Google icon helps, but my attention mainly goes to the VPS text semi-centered.
  • The description is sized larger relative to the login button
  • The black on white on default font is a little... "unpolished" 🥲
  • nit: The UoA logo is a little squished at the top left

Alongside the new design:
image

This design is heavily simplified, removing the main side-bar layout. Simultaneously, I tried to keep most of the content.

Some nice little details have also been included, like the fact that the button now shows a loading spinner when logging in: (helps users if the popup appears on a second monitor, etc.)
image

Regressions

  • The default app background has been changed to an off-white (#f8fafc or slate-50). This means that anything that currently has a white background will need to be updated to be either transparent or match the colour. I have left most of these alone as we will need to update them properly in the future.

Copy link
Contributor

@Kot6603 Kot6603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor

@sbeen56 sbeen56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm:)

Copy link
Contributor

@itsatulbox itsatulbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@wjin-lee wjin-lee merged commit fe97a57 into master Sep 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants