Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend/authoring-tool): deleted the timer component that was not used in the authoring tool #242

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Kot6603
Copy link
Contributor

@Kot6603 Kot6603 commented Sep 23, 2024

Describe the issue

The Dashboard Timer was not removed from the Scene view in the authoring tool despite it not being used anymore.

Describe the solution

Removed the dashboard timer from the authoring tool side bar.

Risk

Could potentially break components that rely on the timer attribute.

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jokes nvm it fails backend tests

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kot6603 Kot6603 merged commit 47b7c3f into master Oct 4, 2024
7 checks passed
@Kot6603 Kot6603 deleted the VPS-72/remove-timer branch October 4, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants