Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the bug: when renaming a scene, the scene breaks (scene.component becomes null) #246

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Kot6603
Copy link
Contributor

@Kot6603 Kot6603 commented Sep 30, 2024

Describe the issue

When renaming a scene from the scene selection page in the authoring tool, the scene breaks (all components deleted and components cannot be added). This was because scene.component became NULL when renaming a scene from the scene selection page.

Describe the solution

The solution was to pass through the component field in the PUT request so that components is also updated in the renamed scene.

Risk

Should not break anything as the component properties already existed (we just didn't update it)

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice catch.

>>>>>> Just make sure you rebase current and that all tests are fixed before you merge.

@Kot6603 Kot6603 merged commit f4c39b6 into master Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants