Vps 45/daisy UI modals #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjin-lee
requested changes
Oct 3, 2024
| <DeleteButton onClick={handleDelete}>Delete</DeleteButton> | ||
| </DialogActions> | ||
| </Dialog> | ||
| <dialog id="my_modal_5" className="modal modal-bottom sm:modal-middle"> |
There was a problem hiding this comment.
Could we give it a more descriptive ID?
package-lock.json
Outdated
There was a problem hiding this comment.
This file should not be included—we are using yarn, not npm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
Modals were using MaterialUI. Need consistent design.
Describe the solution
Refactored modals to use DaisyUI components.
create scenario modal
delete scenario modal
help modal
share modal
reset modal
back modal
image modal
Risk
Buttons are still using MaterialUI.
Definition of Done
Reviewed By
Who reviewed your PR - for commit history once merged