New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pathname used in express initialisation #255

Open

harbassan wants to merge 1 commit into master from fix-pathname

+5 −3

Contributor

harbassan commented Oct 7, 2024

Describe the issue

The backend was crashing because the pathname was still using the old commonjs way and didnt work with esm.

Describe the solution

changed it to use functions built with esm.

Risk

None.

Definition of Done

Code peer-reviewed
Wiki Documentation is written and up to date
Unit tests written and passing
Integration tests written and passing
Continuous Integration build passing
Acceptance criteria met
Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged


          fix: pathname used in express initialisation

245ffc8

wjin-lee approved these changes

View reviewed changes

Member

wjin-lee left a comment

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet