Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/integrate login #50

Merged
merged 10 commits into from
Aug 6, 2024
Merged

Feat/integrate login #50

merged 10 commits into from
Aug 6, 2024

Conversation

fsit869
Copy link
Collaborator

@fsit869 fsit869 commented Aug 4, 2024

Integrated login and register

Upon successful register:

  • Account is created.
  • TODO: Redirect or handle logic afterwards

Upon successful login:

  • Token is stored in localstorage
  • Any calls now using the AxiosAPIInstance will automatically inject the bearer token. So they dont need to worry abt auth
  • TODO: After successful login. Call WhoAmI backend endpoint. Dispatch this data to the redux state.

Backend changes:

  • Added endpoint to check role
  • TODO: Create WhoAmI endpoint. Was not created in this ticket as requires userRepo to get based on ID, which is created in someone elses ticket.

The TODOs are located in comments in the repo.

image

Copy link
Collaborator

@GodYazza GodYazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GodYazza GodYazza merged commit 76a76f0 into main Aug 6, 2024
2 checks passed
@Kinzi-c Kinzi-c deleted the feat/integrate-login branch August 15, 2024 22:09
@GodYazza GodYazza restored the feat/integrate-login branch September 8, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants