Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jolin/admin dashboard #67

Merged
merged 28 commits into from
Sep 28, 2024
Merged

Jolin/admin dashboard #67

merged 28 commits into from
Sep 28, 2024

Conversation

jche521
Copy link
Collaborator

@jche521 jche521 commented Sep 4, 2024 •
edited
Loading

Context

made the admin dashboard page with the following table:
image

Closes

What Changed?

  • add all components (table, admin filter) for the page
  • add user role & status enum (we should start doing this for type consistency??)
  • filter is syncing with the table
  • responsive similar to other pages

How To Review

Risks

  • naming consistency (im currently using Role to specify sponsor/alumni/student, but it can get confusing with user type. Probably need to refactor the naming
  • should start considering using global typing with defined enum & interfaces

jche521 and others added 28 commits September 4, 2024 17:18
@jche521
initialize admin dashbaord structure
a5e3fbd
@jche521
styling of table with round corners
d0a282f
@jche521
style the table and sizing
83d747a
@jche521
tidy up code
d512a5b
@jche521
extract table to a component
4067f20
@jche521
add filter component
1e100be
@jche521
layout of admin wither filters
c90375e
@jche521
attempt to make filter working
7fe2201
@jche521
fix status filtering
05d4d67
@jche521
fix table not rerendering
4d69574
@Kinzi-c
Merge branch 'main' into jolin/admin-dashboard
9134065
@jche521
fix responsive issue with admin dashboard
21c3f88
@jche521
remove unused code and tidy up
7c56777
@Kinzi-c
Merge branch 'jolin/admin-dashboard' of https://github.com/UoaWDCC/fs…
58688bb 
…ae-jobs-board into jolin/admin-dashboard
@jche521
migrate to use datatable
849b69b
@jche521
Merge branch 'jolin/admin-dashboard' of https://github.com/UoaWDCC/fs…
e54468c 
…ae-jobs-board into jolin/admin-dashboard
@jche521
convert bg to black with on hover to grey
cfefad4
@jche521
admin dashboard with pagination
b6d9c1c
@jche521
Revert "admin dashboard with pagination"
fdb35f4 
This reverts commit b6d9c1c.
@jche521
Revert "convert bg to black with on hover to grey"
bb2df19 
This reverts commit cfefad4.
@jche521
Revert "migrate to use datatable"
4b455ff 
This reverts commit 849b69b.
@jche521
pagination done
22e398b
@Kinzi-c
Merge branch 'jolin/admin-dashboard' of https://github.com/UoaWDCC/fs…
66d051b 
…ae-jobs-board into jolin/admin-dashboard
@Kinzi-c
Make boards titles consistent
f99117c
@jche521
Merge branch 'main' into jolin/admin-dashboard (yarn lock brokn)
26e20c3
@jche521
remove yarn lock (no need since we are using npm) abd duplicate function
5e4502f
@Kinzi-c
Merge latest main
47cd523
@Kinzi-c
Fix role.ts conflicts
5eab397
Kinzi-c
Kinzi-c approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@Kinzi-c Kinzi-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Jolin!

@Kinzi-c Kinzi-c merged commit 9294ae7 into main Sep 28, 2024
1 check passed
@Kinzi-c Kinzi-c deleted the jolin/admin-dashboard branch September 28, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kinzi-c Kinzi-c Kinzi-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jche521 @Kinzi-c