107 Broken Members Dropdown #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oculux314
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Concise bugfix, detailed description, great naming and commit conventions, AND implementing additional error checking on your own initiative? Dang this is a really great PR. See one place where I think you can use tailwind rather than inline CSS (references provided!) - fix that and I'm happy to merge!
(P.s. I altered some confusing code from 2023 that was tangentially-related to your PR so do a git pull on this branch before changing anything 😄)
next/components/header/header.tsx
Outdated
| flexDirection: "column", // Stack the years vertically | ||
| alignItems: "center", // Center the text horizontally | ||
| padding: "0.25rem 0.5rem", // Adjust padding to fit the text better | ||
| }} |
There was a problem hiding this comment.
Convert these three to tailwind classes ^
https://tailwindcss.com/docs/flex-direction
https://tailwindcss.com/docs/padding
Oculux314
approved these changes
Aug 28, 2024
|
@kk7-py yo! Two approvals means you've got the go-ahead to merge this into main, GJ :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #107
What Changed?
How To Review
Hover over the members heading on the website to see the hidden dropdown menu, and check if the years are aligned vertically and in descending order.
Checkout
next/components/header/header.tsx
to view the changes.
Review implemented sorting logic and styles