Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

102 Rich Text Bug #116

Merged
merged 9 commits into from
Sep 13, 2024
Merged

102 Rich Text Bug #116

merged 9 commits into from
Sep 13, 2024

Conversation

zozzzC
Copy link
Contributor

@zozzzC zozzzC commented Aug 25, 2024

Context

The current implementation of the Richtext component does not work and does not render Markdown with React Markdown. We want to change this so that changes in Strapi can be rendered as Markdown, making it easier to format text.

Closes #102

What Changed?

  • RichText component (now renders children that are string as richtext)
  • Changed some text colours of the blobs.
  • Add RichText module for styling of markdown.

How To Review

  • Head over to the homepage and the blobs text should look like below. This means the text was rendered as markdown.
image

Notes

  • Richtext has only been applied to blobs.

@YvonneLiew YvonneLiew closed this Aug 28, 2024
@YvonneLiew YvonneLiew reopened this Aug 28, 2024
@YvonneLiew YvonneLiew marked this pull request as draft August 28, 2024 01:13
@zozzzC zozzzC marked this pull request as ready for review August 31, 2024 10:18
Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Beautiful code ✨ and even more beautiful home page 💄

Copy link
Contributor

@h4yleysh4rpe h4yleysh4rpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zozzzC zozzzC merged commit 0bac6b1 into main Sep 13, 2024
@zozzzC zozzzC deleted the 102_rich-text-bug branch September 13, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Text Bug
4 participants