094 make website dynamic #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text size adjustments on about page
Oculux314
reviewed
Aug 28, 2024
strapi/src/index.js
Outdated
| @@ -79,7 +79,7 @@ module.exports = { | |||
| lastname: "Team", | |||
| username: "Younite", | |||
| password: "Developer2023", | |||
| email: "ytao543@aucklanduni.ac.nz", | |||
| email: "543@aucklanduni.ac.nz", | |||
There was a problem hiding this comment.
Yo! Was this an accidental deletion?
…/younite-web into 094_make-website-dynamic
…/younite-web into 094_make-website-dynamic
Oculux314
approved these changes
Aug 29, 2024
|
@zozzzC @jessicazeng13 quick bump on this, Hayley's so excited to merge this in she's fallen sick :) |
|
Hiya, just checking if this was something that was needed to be fixed or not, but in the small screen sizes the About page cards are quite big--is there a reason for that or is it alright that way? |
jessicazeng13
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Everything looks great and is working on my end! I think there are minor styling changes that can be on the values page when it is stacked on top of each other, but I don't think that this is the job for this ticket so don't worry! Great work this looks sick!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Wanted to have the website to be responsive to various browser sizes, and modify all elements to avoid any weird behaviour.
Closes #94
What Changed?
Changes on almost all pages (home/members/about/feedback). Per pages, changes are:
How To Review
Please look at the above changes and ensure that all is running smoothly for various window sizes (can review commit wise if you want to ensure you have checked everything). Please also keep an eye out for any small other problems. Ignore the following as these are issues to be fixed later (after discussing with Nate although let me know if you want me to have a go with any of them soon) -
Notes
Added a new breakpoint into tailwind.css (xs) to allow for a bit more flexibility on the smallest screen sizes.