Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

129 make navbar dynamic #143

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

129 make navbar dynamic #143

wants to merge 15 commits into from

Conversation

h4yleysh4rpe
Copy link
Contributor

Context

Creating a navbar for smaller screen widths, including mobile view. This should not only make it much easier for mobile users to navigate the site, but also help the mobile view compatibility, as the header no longer takes up the same fixed width across the whole page anymore.

Closes #129

What Changed?

  • Created two new components - server-side SmallNavbarFetcher and client-side SmallNavbar.
  • Created arrow svg's which live in the svg folder
  • layout.tsx now contains both header components and renders conditionally based on screeen width
  • Small navbar now shows up instead of the header for screen widths < xs (size in tailwind.config).

How To Review

Can review commit wise. Please check that all commit messages are satisfied as well as -

  • no weird scaling issues, especially for reasonable mobile widths
  • all pages are able to be navigated to

Notes

  • I accidentally called the branch 129_make-branch-dynamic instead of navbar so just keep that in mind sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Navbar dynamic
1 participant