Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

55 belle component #84

Merged
merged 3 commits into from
Jul 23, 2024
Merged

55 belle component #84

merged 3 commits into from
Jul 23, 2024

Conversation

belleyong
Copy link
Contributor

Context

add belle component under dev folder

Closes #55

What Changed?

added belle component

How To Review

just test if the component shows on the belle/mycomponents page

Copy link

@YvonneLiew YvonneLiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

(This is the system file)
Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice component! Looks great feel free to merge!

For next time two small things:

  • Make sure you've read the conventions page for like branch names and stuff
  • Also, there was a random Mac system file that somehow found its way into the PR.
    I've deleted it, but if it crops up again let me know and I'll try figure out why with you!

@belleyong belleyong merged commit b86f2fe into main Jul 23, 2024
@Oculux314 Oculux314 deleted the 55_belle-component branch October 5, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Belle Component
3 participants