Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

060 Hayley Component #85

Merged
merged 1 commit into from
Jul 24, 2024
Merged

060 Hayley Component #85

merged 1 commit into from
Jul 24, 2024

Conversation

h4yleysh4rpe
Copy link
Contributor

…ponent

Context

Created a new Component (HayleyComponent), as well as a page to display it on.

Closes #60

What Changed?

Additional pages inside the test folder, as well as new component in the dev folder.

How To Review

look at the HayleyComponent file inside dev folder and the page.tsx in test/hayley/mycomponent. check that URL extension /test/hayley/mycomponent shows up blue text.

Notes

Component is basic, sorry!

Copy link
Contributor

@zozzzC zozzzC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Very blue

For next time just make sure the branch name format is 060_hayley-component but otherwise this is darn good PR!

Copy link
Contributor

@panmann7 panmann7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@h4yleysh4rpe h4yleysh4rpe merged commit 5b5387e into main Jul 24, 2024
2 checks passed
@h4yleysh4rpe h4yleysh4rpe deleted the 060-hayley-component branch July 24, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hayley Component
4 participants