Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

062 migrate to layout #93

Merged
merged 11 commits into from
Aug 7, 2024
Merged

062 migrate to layout #93

merged 11 commits into from
Aug 7, 2024

Conversation

Oculux314
Copy link
Contributor

@Oculux314 Oculux314 commented Jul 31, 2024

Context

We want to have a consistent page layout for each page.

Closes #62

What Changed?

  • Removed <Header /> and <Footer /> components from each individual page
  • Added footer and header to layout.tsx
  • Adjusted layout.tsx
    • Now contains <main /> (which is now a column flexbox)
    • Header is now positioned absolutely
    • Footer now stays at the bottom of the page if the page is too small
    • Adjusted pages to look like before*

How To Review

  • Start up the app and check nothing's broken on each of the pages!
  • Check out layout.tsx and the home page page.tsx pages first
  • Review code commit-wise

Notes

*New tailwind styles: mt-header and pt-header

Copy link
Contributor

@h4yleysh4rpe h4yleysh4rpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am just wondering whether it would be possible to have the footer moved up slightly on the 404 not found page? (See vid - at the moment you have to scroll to see the footer, which is maybe a bit odd given that the 404 page doesn't really have any content to justify the footer being off the bottom of the page?). I am happy to have a go at this but honestly not sure I'll know how to...

Recording.2024-08-06.112234.mp4

@Oculux314
Copy link
Contributor Author

Looks good to me. I am just wondering whether it would be possible to have the footer moved up slightly on the 404 not found page? (See vid - at the moment you have to scroll to see the footer, which is maybe a bit odd given that the 404 page doesn't really have any content to justify the footer being off the bottom of the page?). I am happy to have a go at this but honestly not sure I'll know how to...

Recording.2024-08-06.112234.mp4

Ah! Don't worry about that that's just Next's default 404 page (which we can't really change).
We should probably make our own, come to think of it... if you're interested keep an eye out!

Copy link
Contributor

@h4yleysh4rpe h4yleysh4rpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@YvonneLiew YvonneLiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Oculux314 Oculux314 merged commit 7cb84c7 into main Aug 7, 2024
@Oculux314 Oculux314 deleted the 062_migrate-to-layout branch August 7, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate To Layout
3 participants