Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

065 home page connector gap #96

Merged
merged 8 commits into from
Aug 7, 2024
Merged

065 home page connector gap #96

merged 8 commits into from
Aug 7, 2024

Conversation

belleyong
Copy link
Contributor

Context

To fix the bug that the connector disconnects.

Closes #65

What Changed?

I've just changed the style of the css into tailwind and Nate has added the Blob.tsx.

How To Review

Check if the connected works on other desktop devices. The connector disconnects at a certain zoom level as it turns into mobile view so please ignore that.

Notes

Copy link
Contributor

@zozzzC zozzzC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, I noticed the connector gap does not seem to work in screen widths smaller than 786px. Just wondering if this is supposed to be accounted for or not.

EDIT: Nevermind, I read your review section. My zoom was at around 90% when this happened. If that's alright then ignore the following.

image

Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Mobile view semi-fixed :D

@Oculux314 Oculux314 requested a review from zozzzC August 7, 2024 01:15
Copy link
Contributor

@zozzzC zozzzC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@belleyong belleyong merged commit 580ffd8 into main Aug 7, 2024
@Oculux314 Oculux314 deleted the 065_home-page-connector-gap branch October 5, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Page Connector Gap
3 participants