ASC 60: Button Implementation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit ac25fa4): https://alzheimercalgary-v2--pr5-asc-60-ygls4zpu.web.app (expires Wed, 21 Feb 2024 06:56:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 49842b2747b50197f445c596a105e7df038b0757 |
PaulHo0501
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Great job! Thank you for your work! Please read me review and make changes. You should also pay attention to the animation of hovering and pressing the button. Because we don't have mock up for those animation, please use your imagination! Be wild! Thanks again.
PaulHo0501
requested changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added buttons and added tests for it