Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kubernetes): remove node group size validation #392

Merged
merged 2 commits into from
Sep 4, 2023
Merged

chore(kubernetes): remove node group size validation #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8452f40
chore(kubernetes): remove node group size validation
thevilledev Jun 29, 2023
6386a15
feat(kubernetes): validate `node_count` is a positive integer
kangasta Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/)
### Added
- gateway: add read-only `addresses` field

### Changed
- kubernetes: remove node group maximum value validation. The maximum number of nodes (in the cluster) is determined by the cluster plan and the validation is done on the API side.

## [2.12.0] - 2023-07-21

### Added
Expand Down
8 changes: 4 additions & 4 deletions internal/service/kubernetes/node_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ func ResourceNodeGroup() *schema.Resource {
ForceNew: true,
},
"node_count": {
Description: "Amount of nodes to provision in the node group.",
Type: schema.TypeInt,
ValidateDiagFunc: validation.ToDiagFunc(validation.IntBetween(0, 16)),
Required: true,
Description: "Amount of nodes to provision in the node group.",
Type: schema.TypeInt,
ValidateFunc: validation.IntAtLeast(0),
Required: true,
},
"name": {
Description: "The name of the node group. Needs to be unique within a cluster.",
Expand Down