refactor(loadbalancer): migrate loadbalancer resource to plugin fw #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villevsv-upcloud
force-pushed
the
refactor/loadbalancer-resolver-pf
branch
from
ac3594e
to
eecbd6f
Compare
villevsv-upcloud
force-pushed
the
refactor/loadbalancer-pf
branch
from
98d746e
to
54822d1
Compare
kangasta
force-pushed
the
refactor/loadbalancer-resolver-pf
branch
from
eecbd6f
to
f9ba921
Compare
kangasta
reviewed
Oct 9, 2024
kangasta
reviewed
Oct 9, 2024
| Family: upcloud.LoadBalancerAddressFamily(n.Family.ValueString()), | ||
| UUID: n.Network.ValueString(), | ||
| } | ||
| if network.Type == upcloud.LoadBalancerNetworkTypePrivate && network.UUID == "" { |
There was a problem hiding this comment.
(No action required) AlsoRequires validator might work for this as well 🤔 Validator would anyway be nicer way to check this, but I guess it would require custom validator so maybe better to look at that later
There was a problem hiding this comment.
Added a plan modifier, so we can check & validate the config after the possible defaults have been set.
kangasta
approved these changes
Oct 9, 2024
villevsv-upcloud
force-pushed
the
refactor/loadbalancer-pf
branch
from
3913ddb
to
46e9e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.