Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff instead of flake8 + isort #126

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

akx
Copy link
Contributor

@akx akx commented Jul 18, 2023

This may have dropped some of the lint rules that were implicitly enabled by hacking being installed, as well as E203 and W503; if that's a problem, I can take a closer look and see what the ruff equivalents are.

warning: Unsupported prefix code: E203
warning: Unsupported prefix code: W503
warning: Unsupported prefix code: H101
warning: Unsupported prefix code: H301
warning: Unsupported prefix code: H306
warning: Unsupported prefix code: H404
warning: Unsupported prefix code: H405

@akx akx marked this pull request as ready for review July 18, 2023 12:18
@ajmyyra
Copy link
Member

ajmyyra commented Jul 18, 2023

Thank you for the PR! Linting by hacking isn't that relevant and we should replace them regardless, so losing them is fine. E203 would seem to be supported. W503 on the other hand is not supported, but I don't consider that a blocker as it's a non-violation and we're fixing a long-standing issue here. Could you rebase the branch so we can get it merged? Thanks again!

@akx
Copy link
Contributor Author

akx commented Jul 18, 2023

@ajmyyra Ah yeah, E203 is a "nursery rule", so it's not activated by default. Since this repo is formatted by black, it's not really relevant anyway. :)

Rebasin'!

@akx akx force-pushed the renovate-tooling branch 2 times, most recently from ea76d6f to 610122d Compare July 18, 2023 17:09
@ajmyyra ajmyyra merged commit 70f03c6 into UpCloudLtd:main Jul 18, 2023
@akx akx deleted the renovate-tooling branch July 21, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants