Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server IP helper functions #131

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Update server IP helper functions #131

merged 2 commits into from
Sep 19, 2023

Conversation

ajmyyra
Copy link
Member

@ajmyyra ajmyyra commented Sep 18, 2023

Server IP helper functions were from a prehistoric era where private networking meant what we currently refer as utility network. Updated functions to use the newer networking attribute in server details, and to also support utility IP addresses with its own helper function.

@ajmyyra ajmyyra requested a review from a team as a code owner September 18, 2023 16:51
upcloud_api/server.py Outdated Show resolved Hide resolved
upcloud_api/server.py Show resolved Hide resolved
Copy link
Member

@Darep Darep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ajmyyra ajmyyra merged commit 05cc031 into main Sep 19, 2023
14 checks passed
@ajmyyra ajmyyra deleted the fix/server-ip-helpers branch September 19, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants