Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list structure #1

Merged
merged 9 commits into from
Jul 20, 2023
Merged

To Do list structure #1

merged 9 commits into from
Jul 20, 2023

Conversation

Uzair-Manzoor
Copy link
Owner

  1. Used webpack project as a template.
  2. Created a branch for this feature.
  3. Added HTML markup to index.html file.
  4. Created a to-do list placeholder.
  5. Set up an array of objects for tasks.
  6. Create a function to iterate through the array.
  7. Added basic style to the list.
  8. Updated the README file.
  9. Fixed linters errors.
  10. Deleted the dist folder.

Copy link

@Alusp Alusp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Uzair-Manzoor,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

congratulations

Highlights

  • Professional PR Summary ✔️
  • Add task successfully ✔️
  • Removed Tasks successfully ✔️
  • Use Js Array ✔️
  • Use Webpack Configurations 🙂

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Uzair-Manzoor in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Uzair-Manzoor Uzair-Manzoor merged commit 872273c into main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants