Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do List Add Remove Functionality #2

Merged
merged 13 commits into from
Jul 21, 2023
Merged

Conversation

Uzair-Manzoor
Copy link
Owner

  1. Created a branch for this feature.
  2. Deleted hardcoded items.
  3. Added a form element to the list.
  4. Created a module for CRUD functionality.
  5. Implemented a method to add a new task.
  6. Implemented a method to delete a task.
  7. Implemented editing task description.
  8. Added some basic styling.
  9. Added the dist folder to the .gitignore file.

Copy link

@Felix45 Felix45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🟢

Hi @Uzair-Manzoor,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights ✔️

  • Good UI design ✅
  • GitHub flow is used correctly ✅
  • Application works as expected ✅
  • Student implemented drag and drop functionality ✅
  • Pull request has a descriptive title and summary ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Uzair-Manzoor Uzair-Manzoor merged commit e2632a2 into main Jul 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants