-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To Do List Add Remove Functionality #2
Conversation
Uzair-Manzoor
commented
Jul 21, 2023
- Created a branch for this feature.
- Deleted hardcoded items.
- Added a form element to the list.
- Created a module for CRUD functionality.
- Implemented a method to add a new task.
- Implemented a method to delete a task.
- Implemented editing task description.
- Added some basic styling.
- Added the dist folder to the .gitignore file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 🟢
Hi @Uzair-Manzoor,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights ✔️
- Good UI design ✅
- GitHub flow is used correctly ✅
- Application works as expected ✅
- Student implemented drag and drop functionality ✅
- Pull request has a descriptive title and summary ✅
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.