To Do list: interactive list

[Uzair-Manzoor]

This pull request has been created against implementing the following requirements into the project:

• Added a new JavaScript file and import it as a module:
• Added event listener to the checkbox (change).
• Updated items object's value for completed key upon user actions.
• Implemented function for the "Clear all completed"
• Stored the updated array of items in local storage
• Live Demo Link

[levy002]

Hello @Uzair-Manzoor , 👋

I'm Levy, your PR reviewer

Good job so far 👍
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

• No linter error ✔️

Status: REQUIRED CHANGES ♻️

Check the comments under the review.

• Kindly make sure to update the tasks index after clearing all completed tasks. Remember always task index should start at 1 (if the task is the fourth it'sindex should always be 4)

  CODE SUGGESTION IN clearTask.js

      const clearAllCompletedTasks = () => {
  const filteredTasks = tasks.filter((task) => !task.completed);
  filteredTasks.forEach((task, newIndex) => {
  task.index = newIndex + 1;
  });
  
  tasks.length = 0;
  tasks.push(...filteredTasks);
  storeTasksToLocalStorage();
  };
  
  
  

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @levy002 in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[Uzair-Manzoor]

Hi @levy002, thank you for the feedback. Changes have been made accordingly.

• task index should start at 1 (if the task is the fourth it's index should always be 4)

[danmainah]

Hi @Uzair-Manzoor ,

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉 🎉 🎉

Highlights

✔️ Implemented change requested to ensure tasks index update after the user clears the completed tasks.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.