refreshing JavaScript best practices #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript best practices
General practices
script
tag.JavaScript in the browser
console.log
to your repo. It’s ugly, it kills performance and it can make confidential data be visible to anyone using the browser tools to look at your website.window.alert()
orwindow.confirm()
. It’s ugly, impossible to style, it stops code execution and displays differently on different browsers. Use custom modal instead.document.write
oreval
node_modules
dir to your .gitignore file as all those files are not needed in your repo (each team member will install all packages thanks to your package.json file).